search

color-js / color.js

Color conversion & manipulation library by the editors of the CSS Color specifications
https://colorjs.io
MIT License
1.89k stars 82 forks source link

Fix serialization of negative percentages #554

Closed lloydk closed 3 months ago

lloydk commented 3 months ago

Closes #552

Changes the hard coded percentage ranges to a variable range based on whether or not the lower bounds of the range is < 0. Spaces that do not have coordinate ranges (e.g. xyz-d65) will have a percentage range of [0, 1] and [0, 100].

netlify[bot] commented 3 months ago

Deploy Preview for colorjs ready!

Name Link
Latest commit 0ede7fc1095509cefd62b5ea056b1dba344fd848
Latest deploy log https://app.netlify.com/sites/colorjs/deploys/666e3cff3c5e9b000945bcb6
Deploy Preview https://deploy-preview-554--colorjs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LeaVerou commented 3 months ago

Gah, now this introduces an error, since we changed the name of the function but not of the function calls. The suggestion was indicative, sorry if that wasn't clear!

lloydk commented 3 months ago

Gah, now this introduces an error, since we changed the name of the function but not of the function calls. The suggestion was indicative, sorry if that wasn't clear!

Oops, I was watching tv and wasn't really paying attention.