color-js / color.js

Color conversion & manipulation library by the editors of the CSS Color specifications
https://colorjs.io
MIT License
1.81k stars 80 forks source link

Fix remaining type test failures #569

Closed lloydk closed 1 week ago

lloydk commented 1 week ago

Fixes the remaining type test failures. 🤞

netlify[bot] commented 1 week ago

Deploy Preview for colorjs ready!

Name Link
Latest commit 3dab629d71f376e1c1d6debba9b33681c7865e15
Latest deploy log https://app.netlify.com/sites/colorjs/deploys/667d01629bec590008164246
Deploy Preview https://deploy-preview-569--colorjs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jgerigmeyer commented 1 week ago

These changes look good, but CI is still reporting a number of type test errors. Is that expected?

MysteryBlokHed commented 1 week ago

Would you mind checking whether the errors are from the tests, or the codebase itself? I'm on mobile right now, so I can't.

jgerigmeyer commented 1 week ago

The errors are from dtslint -- likely related to: https://github.com/color-js/color.js/pull/571#issuecomment-2195420830