search

color-js / color.js

Color conversion & manipulation library by the editors of the CSS Color specifications
https://colorjs.io
MIT License
1.81k stars 80 forks source link

Run build:ts in lint and lint:ci #571

Closed lloydk closed 1 week ago

lloydk commented 1 week ago

Due to typescript errors in the code base the tsc portion of build:ts is hardcoded to always return a 0 exit code.

This should work on Linux and Mac (I only tested it on Linux). If we want to support building on Windows then we need a different strategy for the exit code. There are a number of npm packages that will handle the exit code in a cross platform manner. (e.g. https://github.com/kachkaev/suppress-exit-code).

netlify[bot] commented 1 week ago

Deploy Preview for colorjs ready!

Name Link
Latest commit a7e94faaf2a4a3090eb189508d810854e9bc1f67
Latest deploy log https://app.netlify.com/sites/colorjs/deploys/667d9e9fc28bdc000832edac
Deploy Preview https://deploy-preview-571--colorjs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

lloydk commented 1 week ago

I'm confused as to why there are so many dtslint errors in CI. I cloned this repository into a new directory, did an npm install added the changes in this PR ran npm run lint:ci and got a different set of dtslint errors (errors fixed by #569).