color-js / elements

WIP
12 stars 1 forks source link

First pass at colorchange event #10

Closed LeaVerou closed 4 months ago

LeaVerou commented 4 months ago

Why on earth is this not working?

netlify[bot] commented 4 months ago

Deploy Preview for color-elements ready!

Name Link
Latest commit c4a847222c57f4954856afd22c68ce1830e3696d
Latest deploy log https://app.netlify.com/sites/color-elements/deploys/663a2e53ebbb120008b817bc
Deploy Preview https://deploy-preview-10--color-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DmitrySharabin commented 4 months ago

I also noticed that <color-sliders> with “standard” attributes (min, max, value) are broken (they don’t handle the colorchange event). If you remove those attributes, the sliders start working as they should.

UPDATE. FIxed with the current changes.