search

color-js / elements

WIP
12 stars 1 forks source link

[color-swatch] Switch to `defaultProp` for `color` #106

Closed DmitrySharabin closed 2 months ago

netlify[bot] commented 2 months ago

Deploy Preview for color-elements ready!

Name Link
Latest commit dbc495ac6eb8ca06a0953a19cb1de0e84cda4eac
Latest deploy log https://app.netlify.com/sites/color-elements/deploys/6671d5e9e05b2300087192a8
Deploy Preview https://deploy-preview-106--color-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DmitrySharabin commented 2 months ago

I had to revert it and force push (so these changes are not in the commit history). The changes from this PR led to the regression we fixed by switching to a getter and a setter.

@LeaVerou, I'm pinging you to let you know that we need to work on this a bit more.