search

color-js / elements

WIP
14 stars 1 forks source link

[color-chart] Completely broken in Safari #122

Closed DmitrySharabin closed 4 weeks ago

DmitrySharabin commented 1 month ago

https://elements.colorjs.io/src/color-chart/

DmitrySharabin commented 1 month ago

After switching to the common base ColorElement class, we again encountered the same bug with the top-level await we had already worked around once.

If we look at the version of the site before that change, everything (well, except the first buggy chart) works fine.

LeaVerou commented 1 month ago

I was planning to inline https://github.com/color-js/elements/blob/main/src/common/color.js inside https://github.com/color-js/elements/blob/main/src/common/color-element.js Maybe try if that fixes it?

DmitrySharabin commented 1 month ago

I was planning to inline https://github.com/color-js/elements/blob/main/src/common/color.js inside https://github.com/color-js/elements/blob/main/src/common/color-element.js Maybe try if that fixes it?

Unfortunately, it didn't work.

DmitrySharabin commented 4 weeks ago

Fixed in aebac4eadf63a0299be9290e8688ab43bb0ff2c2.