[color-scale][color-chart] Export the `gamut` part and hide it in charts, fixes #130

color-js / elements

WIP

14 stars 1 forks source link

Closed DmitrySharabin closed 3 weeks ago

netlify[bot] commented 1 month ago

Name	Link
Latest commit	8dc5a88ae16dedeb835c4862449689ac2f0d6a28
Latest deploy log	https://app.netlify.com/sites/color-elements/deploys/6728994751942f00080539f3
Deploy Preview	https://deploy-preview-142--color-elements.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LeaVerou commented 1 month ago

Not sure if we should hide it or just make it way smaller.

DmitrySharabin commented 1 month ago

Not sure if we should hide it or just make it way smaller.

I'm not sure if it's a valid option, but might we combine it with the rest of the information we have about the color (label, coords, etc.)?

LeaVerou commented 1 month ago

That would be much harder to implement. Can you try making it smaller (via font-size) and see how it looks?

DmitrySharabin commented 3 weeks ago

That would be much harder to implement. Can you try making it smaller (via font-size) and see how it looks?

Here is how it looks with font-size: 50%:

LeaVerou commented 3 weeks ago

I think even smaller than that might work (40%?), and let's make sure to expose it as a part on color-chart so that people can easily hide it.

DmitrySharabin commented 3 weeks ago

I think even smaller than that might work (40%?)

I think it does indeed:

let's make sure to expose it as a part on color-chart so that people can easily hide it.

If I get it right, we have it in this PR.