search

color-js / elements

WIP
14 stars 1 forks source link

[channel-picker] First iteration #147

Closed DmitrySharabin closed 2 weeks ago

DmitrySharabin commented 2 weeks ago

Partially addresses #124.

It's a bare minimum, just for a start.

Docs: https://deploy-preview-147--color-elements.netlify.app/src/channel-picker/

netlify[bot] commented 2 weeks ago

Deploy Preview for color-elements ready!

Name Link
Latest commit 66715226733b68c8cdd4d11eddbd4fc2ff54161b
Latest deploy log https://app.netlify.com/sites/color-elements/deploys/672e0316da99d500088d32de
Deploy Preview https://deploy-preview-147--color-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DmitrySharabin commented 2 weeks ago

I addressed all your feedback. Thank you!

I also made the picker more resistant to and tolerant of user errors. I would be grateful for your following review.

DmitrySharabin commented 2 weeks ago

I'd render it as either separate dropdowns that are side by side or a "segmented" control, where there is a line down the middle. And the border color should be way fainter in any case.

Thank you for your feedback. I ended up with a "segmented" control. We can improve it with the next iterations.

image
LeaVerou commented 2 weeks ago

Yeah. One issue with the current styling is that it doesn't communicate the hierarchy, that Lightness is a coordinate of Oklch, they look like peers.