First attempt to fix issue #16

DmitrySharabin commented 4 months ago

For now, it doesn't fix anything—what was broken previously is still broken. Why? At the element initialization, this.tooltip is undefined, so the spinner will get its values for min, max, and step from the corresponding properties of the slider.

Currently, after <color-slider> is initialized, min, max, and step remain unchanged, which means the corresponding values of the spinner aren't being updated. I'm trying to find a solution to this.

@LeaVerou Is there a proper way to call propChangedCallback()(or something else) for min, max, and step after the <color-slider> is initialized. I suspect it's possible to do from connectedCallback(), but I'm unsure how to do it properly.

netlify[bot] commented 4 months ago

Deploy Preview for color-elements ready!

Name	Link
Latest commit	b1686eb78c7adb61ce56c7eec6662bd9f5ca48b4
Latest deploy log	https://app.netlify.com/sites/color-elements/deploys/6644b04c7b6ce20008aa7909
Deploy Preview	https://deploy-preview-33--color-elements.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DmitrySharabin commented 3 months ago

I'm closing this in favor of a better (from my perspective) fix: #88.

color-js / elements