[color-picker] Fix issues

color-js / elements

WIP

14 stars 1 forks source link

Closed DmitrySharabin closed 5 months ago

DmitrySharabin commented 5 months ago

Get rid of render()—all the changes are handled with handleEvent() and propChangedCallback()
When space is set, we should update color (if it was previously set) accordingly
<color-swatch> doesn't have the color attribute, so when the <color-picker>'s color prop changes, we should propagate changes to the swatch, and update its property, not the attribute

Note: Until #85 is fixed, we might face issued with the swatch (like #84).

netlify[bot] commented 5 months ago

Name	Link
Latest commit	7b912f9d4b51469732b8fde3c119fb3ddc760524
Latest deploy log	https://app.netlify.com/sites/color-elements/deploys/6660712193bb4c0008bab606
Deploy Preview	https://deploy-preview-87--color-elements.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.