Closed DmitrySharabin closed 3 months ago
Name | Link |
---|---|
Latest commit | c362771b08f5fb6f07533cd2684382f411839f04 |
Latest deploy log | https://app.netlify.com/sites/color-elements/deploys/6668066ed51d1b0008daad40 |
Deploy Preview | https://deploy-preview-93--color-elements.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I addressed all your feedback. Thank you so much! It should be ready now for another iteration.
I addressed all your feedback. Thank you!
Before requesting your review again, I'd love to know if there is a way to output formatted values for coordinates (the way they are displayed in the parsed color). We might get a result much closer to the one you showcased in the issue:
No, but that's an excellent feature request for getAll()
.
No, but that's an excellent feature request for
getAll()
.
Do you mean Color.getAll()
in Color.js
? Should I file an issue?
No, but that's an excellent feature request for
getAll()
.Do you mean
Color.getAll()
inColor.js
? Should I file an issue?
Yes
Don't worry about formatting for now, just apply precision. We'll deal with formatting in Color.js.
Don't worry about formatting for now, just apply precision. We'll deal with formatting in Color.js.
Sure. Just to ensure I follow: we can do it like this: value.toPrecision(4)
. Right? Or do we have a way to get the needed precision with Color.js
(with some feature I'm not yet aware of š«£)?
UPDATE value.toPrecision(4)
add zeroes to all the values (e.g., 0.1500
). Can't say I like it.
UPDATE 2 This works fine: +value.toPrecision(4)
.
Yup, +value.toPrecision()
.
It's a very basic implementation, so we could have something to start with. š It looks like this:
When defining the type of
coords
, I used a workaround because of the issue I faced.I wonder whether we should do something like
+(value).toPrecision(4)
to make the output look nicer (or is it OK to see that many digits?). Is there a way to specify precision inColor.js
we could use?UPDATE
Here is the code that produces the image above: