[color-scale] Fails to parse functional colors with commas

color-js / elements

WIP

12 stars 1 forks source link

[color-scale] Fails to parse functional colors with commas #94

Closed LeaVerou closed 3 months ago

LeaVerou commented 3 months ago

DmitrySharabin commented 3 months ago

Actually, functional colors are parsed correctly if there are no commas. We use comma as a default separator when parsing entries:

https://github.com/nudeui/element/blob/eebac9359bf0eb32da7e3fb406716f35a7247677/src/props/types/dictionaries.js#L4

LeaVerou commented 3 months ago

I pushed a change to Nude Element that fixes this. I’m still unsure about it, I think it should probably be opt in for some of these pairs at least but oh well.