search

colored-rs / colored

(Rust) Coloring terminal so simple you already know how to do it !
Mozilla Public License 2.0
1.68k stars 82 forks source link

Replace `lazy_static` with `once_cell` #119

Open Yesterday17 opened 1 year ago

hwittenborn commented 1 year ago

Could you merge this repo's master branch into your's so that the CI can run @Yesterday17?

LingMan commented 1 year ago

Could you merge this repo's master branch into your's so that the CI can run @Yesterday17?

That would create useless merge commits polluting the history. The correct operation would be to rebase onto current master. Just FYI.

hwittenborn commented 1 year ago

I was planning on doing a squash merge once the PR got in anyway @LingMan, so it shouldn't matter much.

LingMan commented 1 year ago

Ah, I see. The squash button does still add the title of the merge commit to the commit message, but it is an improvement over leaving them separate. Personally I'm always annoyed when maintainers squash my carefully separated commits into one messy pile. Since there's only one real commit here that obviously doesn't apply though. (Not to mention that I'm not the author here, so I'll shut up now.)

Yesterday17 commented 1 year ago

Could you merge this repo's master branch into your's so that the CI can run @Yesterday17?

Done.

kurtlawrence commented 9 months ago

Could this been done with https://doc.rust-lang.org/std/sync/struct.Once.html ?