Document the current MSRV in the manifest

colored-rs / colored

(Rust) Coloring terminal so simple you already know how to do it !

Mozilla Public License 2.0

1.74k stars 84 forks source link

Document the current MSRV in the manifest #142

Closed LingMan closed 1 year ago

LingMan commented 1 year ago

Cargo will support MSRV aware dependency resolution in the future by relying on this field. Let's not rely on whatever heuristic it will use for crates not specifiying their MSRV.
Clippy will not suggest changes that would require a newer version of Rust than specified. Important for not failing CI when applying the suggested change would force a raise of the MSRV.

LingMan commented 1 year ago

Updated to reflect the new MSRV after the switch to is-terminal.

hwittenborn commented 1 year ago

Whoops, I was in a rush and didn't even realize this PR was open and had made #146.

Would you mind merging in this repo's msrv branch into here @LingMan? I'd be more than fine getting this merged in if so.

LingMan commented 1 year ago

There are several different things going on in the one commit of that branch. Some of which would fit here and some which probably should be changed. For attribution reasons, it would probably be easier to fix up your PR and close this one.

hwittenborn commented 1 year ago

I'd hate to not give you attribution when you still made this PR though @LingMan :P. Would you be fine with me marking you as a co-author on that PR?

LingMan commented 1 year ago

Eh, I couldn't care less about attribution for a one liner like this.

hwittenborn commented 1 year ago

Alright, sounds good. Thanks a ton for the PR regardless!