search

colored-rs / colored

(Rust) Coloring terminal so simple you already know how to do it !
Mozilla Public License 2.0
1.74k stars 84 forks source link

Switch to std::io::IsTerminal for v3 #144

Closed kurtlawrence closed 4 days ago

kurtlawrence commented 1 year ago

For the v3 release, switch to using std::io::IsTerminal.

juntyr commented 1 year ago

+1 from me for removing the atty dependency

Oakchris1955 commented 1 year ago

I opened a PR (#149) which uses the built-in trait instead of the external crate. I hope it get approved by the maintainers

hwittenborn commented 1 year ago

Thanks for the PR @Oakchris1955! I'll get that merged in once the v3 branch gets created - there's a few other PRs that need to get merged, and then I'll get that looked at.

Oakchris1955 commented 4 days ago

Since this was basically resolved with 2.1, shouldn't this issue be closed?