search

colored-rs / colored

(Rust) Coloring terminal so simple you already know how to do it !
Mozilla Public License 2.0
1.73k stars 83 forks source link

Make crate MSVR 1.63 #146

Closed hwittenborn closed 1 year ago

hwittenborn commented 1 year ago

I'd like you to review this before it gets merged @kurtlawrence, especially the version policy for when the MSRV gets bumped (see README.md in the changed files).

If you don't think the minor version approach is good I'm down for discussing alternatives.

hwittenborn commented 1 year ago

Are you a regular contributor to the crate @LingMan? It seems like you're quite good at reviewing stuff, and I'd like to add you to here somehow (even if just as a reviewer) if you'd be down with it :).

LingMan commented 1 year ago

Are you a regular contributor to the crate @LingMan?

You mean to colored? So far I have a grand total of zero commits merged here. No clue how any of it works either, so adding me as a reviewer is not something I'd advise to do.

hwittenborn commented 1 year ago

Alright that sounds good @LingMan, just throwing it out as an offer! If you ever want to I'm definitely down though :)

hwittenborn commented 1 year ago

Sounds great! I'll go ahead and get this merged then :)