search

colorfy-software / react-native-modalfy

🥞 Modal citizen of React Native.
https://colorfy-software.gitbook.io/react-native-modalfy
MIT License
1.08k stars 44 forks source link

Code Refactoring #1

Closed khaledosman closed 5 years ago

khaledosman commented 5 years ago
lucasmotta commented 5 years ago

Some pretty solid changes on this PR - @khaledosman do you think you could rebase your changes and resolve the conflicts? Then @CharlesMangwa could probably help approving and merging!

lucasmotta commented 5 years ago

Hey @CharlesMangwa, any chances that this could get merged and maybe a new version release? There are some methods like closeAllModals that is only available on master at the moment.

CharlesMangwa commented 5 years ago

Hi @lucasmotta! First of all: thanks for checking out react-native-modalfy! Almost all the changes @khaledosman brought are already available in the current 0.1.1. I didn't have time to work on RNM and they're still some changes that actually break the library, that's why this PR hasn't been merged yet.

About the changes and new methods you're seeing on master: they're breaking changes so that imply the next version will be a major one (1.0.0). We'd like to bring unit tests, update the docs, etc before getting there, which might take a tiny bit because we've some other priorities right now. However, if you really need those new methods, feel free to install the library from the latest version on master and I could guide you through the new things if needed! We'll do our best to get 1.0.0 to you in the as soon as practicable

CharlesMangwa commented 5 years ago

@lucasmotta Just a heads up for you: react-native-modalfy@1.0.0-beta.0 is out with all the new features! The documentation will be updated as soon as we can but feel free to browse the source code or ask us for any help in the meantime!