Modal is opened again after close the first one

[willymai]

You can check reproduce example here https://snack.expo.dev/@willymai/duplicate-modal

Modal is opened twice after clicking button to close the current modal

Reproduce step

• Test case 1
  • Click Press me button to open modal
  • Click Ok to close modal
  • repeat click Press me and Ok button
  • => modal open again

Test case 2:

• Click Press me button to open modal
• Click on background to close modal
• Do Test case 1
• open will re-open more than 2 times

with "react-native-modalfy": "3.5.1"

[DovletAmanov]

I face same issue with version 3.5.1. Issue goes away if I remove transitionOptions from animation config. Version 3.4.0 seems fine, temporarily downgraded.

[Fagner3g]

I face same problem here.

[CharlesMangwa]

@willymai thanks for reporting this issue! i'll be looking into asap, just have some other urgent matters to take care of before i can have some time to work on modalfy.

@DovletAmanov thank you for the info, that will help find the root cause of this issue!

[CharlesMangwa]

hey @willymai @DovletAmanov @Fagner3g! i think i may have fixed it actually! turned out it was an issue i stumbled upon in our own apps but in a different form. however, the fix was similar.

long story short: the issue was coming from an unnecessary use of the finished argument provided to the Animated.some_method().start()'s callback. as mentioned in react native's doc, that finished is not a boolean that indicates if the animation is done running (and therefore a callback can now be invoked). it actually simply indicates if the animation was interrupted or not while running. simply providing a callback method is enough to make sure that it'll be invoked once the animation is done (either fully or because it was interrupted): https://reactnative.dev/docs/animated#working-with-animations.

modalfy docs & examples should have all been updated to reflect that by removing any use of finished. i would recommend you do the same if you were also using finished in your apps for the modal config.

please let me know if v3.5.2 fixes this issue on your side!

[sivantha96]

The issue persists on v3.5.2 as well. as @DovletAmanov suggested 3.4.0 works fine.

[WooMinGy]

The same issue still persists on v3.5.2. @CharlesMangwa