[iOS] open modal when screen has options presentation: "modal"

colorfy-software / react-native-modalfy

🥞 Modal citizen of React Native.

https://colorfy-software.gitbook.io/react-native-modalfy

MIT License

1.06k stars 41 forks source link

[iOS] open modal when screen has options presentation: "modal" #125

Closed vietanhdtd closed 2 days ago

vietanhdtd commented 9 months ago

I have encountered a problem when using a modal on a screen that has the option presentation: "modal". The modal always shows up behind it.

To address this issue, I came up with a workaround that involves wrapping the screen content with ModalProvider. However, this approach results in opening two modals, and I am unable to close the modal on a screen with presentation: "modal".

If anyone has a better solution for this case, please share it with me. Thank you.

CharlesMangwa commented 9 months ago

hey @vietanhdtd! could you provide a repro on snack please?

vietanhdtd commented 9 months ago

@CharlesMangwa thank you for responding. Here's snake of the problem i mention above:

https://snack.expo.dev/@vietanhdtd/modalfy-screen-presentation-modal

CleanShot 2023-09-25 at 11 54 51

And only happen on iOS.

CharlesMangwa commented 4 months ago

hey @vietanhdtd! sorry for the delayed response. unfortunately, i do not have an idea how to address your issue effectively. i'd need to spend some more time trying things before i can potentially release a patch. apologies for the inconvenience.

fobos531 commented 1 week ago

Hello @CharlesMangwa, I opened a PR #149 which fixes this