search

colorfy-software / react-native-modalfy

🥞 Modal citizen of React Native.
https://colorfy-software.gitbook.io/react-native-modalfy
MIT License
1.06k stars 41 forks source link

fix: displaying the modal in a screen with presentation: modal on iOS #149

Closed fobos531 closed 2 days ago

fobos531 commented 1 week ago

Fixes https://github.com/colorfy-software/react-native-modalfy/issues/125

This is actually a super simple solution, all that is needed is to just wrap the ModalStack in a FullWindowOverlay provided by react-native-screens.

This now works on iOS both with presentation: modal and regular screens.

The behavior is unchanged on Android since it is unaffected by this problem.

@CharlesMangwa I would very much appreciate if you could take a look at this and review it.

Also, there are a couple of things that could be done to modernise this library, like updating gesture handler to v2, as well as migrating to Reanimated. Would you be open to reviewing a PR doing the migration to reanimated 3, like https://github.com/colorfy-software/react-native-modalfy/pull/68?

CharlesMangwa commented 2 days ago

hey @fobos531!

thanks a lot for the pr, that's a nice fix indeed 👍

i would be more than happy to welcome a pr that'd bring rngh v2 reanimated v3!

unfortunately, i do not have much time to work on it myself lately but if you're up for it, just let me know how i could be of any assistance.