search

colorfy-software / react-native-modalfy

🥞 Modal citizen of React Native.
https://colorfy-software.gitbook.io/react-native-modalfy
MIT License
1.08k stars 44 forks source link

createModalStack: 'backdropOpacity: 0' falls back to the default value #19

Closed v-honcharenko closed 4 years ago

v-honcharenko commented 4 years ago

When using 0 for backdropOpacity, it falls back to default value.

const stack = createModalStack(modalConfig, {
  backdropOpacity: 0,
});

The issue is in this line: https://github.com/colorfy-software/react-native-modalfy/blob/df2bf5c66efef76a1ba4c3a3b41fcc6cafb8c9f1/lib/ModalStack.tsx#L133 The || operator should be changed to ??.

CharlesMangwa commented 4 years ago

Hey @HackedBeat! Thanks for the bug report and the quick fix!