colorfy-software / react-native-modalfy

🥞 Modal citizen of React Native.
https://colorfy-software.gitbook.io/react-native-modalfy
MIT License
1.08k stars 44 forks source link

Move animation logic to react-native-reanimated. #36

Closed shubhamdeol closed 3 years ago

shubhamdeol commented 3 years ago

Currently frames are dropping when opening and close the modal. I am using this library in my App. My app drops the frame when opening and closing the modal. There are no extra renders in my component only issue can be Animation implementation under the hood.

shubhamdeol commented 3 years ago

Closing the issue, looks performance reasons on android are not due to animation implementation. As this library is context under the hood. using openModal function useModal hook causes re-render of all the screens. fixed the issue by opening modal from javascript side.