search

colorfy-software / react-native-modalfy

🥞 Modal citizen of React Native.
https://colorfy-software.gitbook.io/react-native-modalfy
MIT License
1.06k stars 42 forks source link

Refactor: Migrate to reanimated 2 #68

Open ngocle2497 opened 2 years ago

ngocle2497 commented 2 years ago

This PR uses Reanimated 2 to be supported by JSI instead of Bridge

CharlesMangwa commented 2 years ago

Hey @MasonLe2497! Thank you for this great PR! I've been thinking about switching Modalfy to Reanimated v2 for a long time, just was waiting to ship some other features & fixes before that. I'll go over your PR and try to get it merge as soon as I'll have a minute! 💪

ngocle2497 commented 2 years ago

I tested on android device, and it works with 60fps https://user-images.githubusercontent.com/43195241/157888496-336df1f1-d2c0-4dad-aeb4-2abeb29b9c4d.mov

ngocle2497 commented 2 years ago

But with this PR, transitionOptions must be a 'worklet' function return ViewStyle

CharlesMangwa commented 2 years ago

Yeah, I suspected that the switch to Reanimated 2 would be a breaking change and would require a major app update, shouldn't be much of an issue if the doc has proper migration guide.

LeviWilliams commented 2 years ago

Hey! I'm looking into migrating to this library and v2 reanimated support is something on our list, is there any chance this is on the docket still? Love the lib design so far too nice work

LeviWilliams commented 2 years ago

@MasonLe2497 Thinking about patching this into my project, have you used in production at all? Thanks!

tonihm96 commented 1 year ago

hey! is this still being worked on? I'd love to see modalfy having support for reanimated 😄

CharlesMangwa commented 1 year ago

hi @Tonihm96. no this is currently not being worked on. we'll try to keep you posted once this gets on top of our todo list 👍

GaeCuure commented 12 months ago

would love to see modalfy having support for reanimated !