search

colorjs / color-normalize

Convert any color data format to sanitized channels array
10 stars 4 forks source link

Bump color-rgba 2.1.1 - module color-normalize #4

Closed archmoj closed 5 years ago

archmoj commented 5 years ago

Include fix for https://github.com/colorjs/color-parse/issues/1 @dy cc: @etpinard

archmoj commented 5 years ago

It seems that one test is not compatible with current "stable" node version 12.3.1. The previous successful run on a "stable" version was performed on node version 10.5.0: https://travis-ci.org/colorjs/color-normalize/jobs/395637825.

etpinard commented 5 years ago

@archmoj do you have an idea why tests are failing in node 12?

archmoj commented 5 years ago

The issue was with node 12 & not with color-rgba 2.1.1 as reported here: https://github.com/colorjs/color-normalize/issues/3 (tests are failed even on the master branch when using node 12)!

The test is fixed to work with node 12. @dy would you mind having the second look at this PR? Thanks.

archmoj commented 5 years ago

@dy could you possibly release a patch from this? Many thanks.

zeke commented 5 years ago

Looks good to me. I'd merge it, but I'm not an owner of the npm package.

archmoj commented 5 years ago

Thanks @zeke for the review. Great news! Then we could wait for @dy for the npm package.

archmoj commented 5 years ago

@dy any chance we have a patch release this week? Thanks.

dy commented 5 years ago

Sorry for the delay. Done.