search

colour-science / colour-demosaicing

CFA (Colour Filter Array) demosaicing algorithms for Python
https://www.colour-science.org
BSD 3-Clause "New" or "Revised" License
285 stars 58 forks source link

Demosaicing does not return clipped values #3

Closed timmeinhardt closed 7 years ago

timmeinhardt commented 7 years ago

Demosaicing a normalized bayer image with float values between 0 and 1 using the _demosaicing_CFA_BayerMalvar2004 method does not return a clipped image. This should either be mentioned in the documentation or demosaicing methods should finish with an appropriate clipping step since without noticing this behaviour the resulting PSNRs are significantly worse.

KelSolaar commented 7 years ago

That is a good point, at the moment none of the demosaicing definitions are clipping return values which is kind of consistent with everything we do for Colour or any related projects like this one.

The benefit in that particular case is that it allows for demosaicing HDR images: you merge the CFA bayer sensor data and then perform demosaicing as this Jupyter Notebook showcases it. If you were to clip the demosaiced output you would obviously lose all the dynamic range.

That being said I'll make a note in the definition.

Cheers,

Thomas

timmeinhardt commented 7 years ago

I did not know about the HDR application wich makes perfectly sense. A note in the documentation is totally fine then. This can be closed. Thanks for your fast response!

KelSolaar commented 7 years ago

You are welcome :)