PR: Support for pixels with a value of zero.

colour-science / colour-demosaicing

CFA (Colour Filter Array) demosaicing algorithms for Python

https://www.colour-science.org

BSD 3-Clause "New" or "Revised" License

285 stars 58 forks source link

PR: Support for pixels with a value of zero. #4

Closed MadsDyrmann closed 7 years ago

MadsDyrmann commented 7 years ago

The existing convolutions caused pixels with a value of zero to underflow. Problem is solved by performing floating point convolutions, and clipping negative pixel values to zero. nb. scipy.signal dependency is added

KelSolaar commented 7 years ago

Hi @MadsDyrmann, thanks!

It is quite hard to review your PR as you have two commits in a row, one doing some stuff and one undoing it straight after. Would it be possible to squash them as a single one (and force push to your branch).

The unit tests are failing also on travis-ci.

KelSolaar commented 7 years ago

@MadsDyrmann: Any word on that PR?

Cheers,

Thomas

KelSolaar commented 7 years ago

Closing for inactivity.