search

colour-science / colour

Colour Science for Python
https://www.colour-science.org
BSD 3-Clause "New" or "Revised" License
2.03k stars 257 forks source link

PR: Implement support for *isort*. #1211

Closed tjdcs closed 8 months ago

tjdcs commented 9 months ago

Summary

Code format enforcement is good, and we have a lot if import order issues with PEP8.

Luckily I think isort can fix that.

tjdcs commented 9 months ago

Running CI on this branch to see how it does. My local environment thinks everything passes but has a few other errors related to my early adoption of MacOS Sonoma 14.0

coveralls commented 9 months ago

Coverage Status

coverage: 99.798%. remained the same when pulling 42c2cf4199eef3bfcfbfee53d5a4fe64fee7e430 on feature/isort into 87d322cb57fbf3d9bdd537f9bb53c0f714dddee4 on develop.

tjdcs commented 9 months ago

note this is a branch from #1209 which should be resolved first!

KelSolaar commented 9 months ago

Great and thanks! I will be able to tick that one off from the bottomless stack of things todo:

image

tjdcs commented 9 months ago

Great and thanks! I will be able to tick that one off from the bottomless stack of things todo:

Woot!

I don't intend to make any changes so if you think the project toml and pre-commit config looks good then this is ready for develop