search

colour-science / colour

Colour Science for Python
https://www.colour-science.org
BSD 3-Clause "New" or "Revised" License
2.03k stars 257 forks source link

[FEATURE]: Implement smooth D and ID illuminants in CIE 204:2013 "Methods for Re-defining CIE D Illuminants" #1242

Open Artoria2e5 opened 5 months ago

Artoria2e5 commented 5 months ago

Description

CIE 204:2013 "Methods for Re-defining CIE D Illuminants" (https://cie.co.at/publications/methods-re-defining-cie-d-illuminants) defines a number of "highly smoothed" versions of the D and ID illuminants. They are referenced in https://www.oscars.org/sites/oscars/files/ssi_overview_2020-09-16.pdf.

PS. colour also doesn't seem to have a thing for "D illuminant of arbitrary CCT"? There are basis functions, but I don't see anything mixing them together.

PPS. The documentation on top of https://github.com/colour-science/colour/blob/develop/colour/colorimetry/datasets/illuminants/sds.py is not getting rendered on the website, as the API doc switched to a more RST-driven approach.

(No, I don't need it for anything. I'm just being a squirrel and collecting stuff.)

KelSolaar commented 5 months ago

Hello @Artoria2e5,

Thanks, I vaguely remember seeing those versions of the CIE illuminant D series but we never implemented them. That could be an interesting thing to add for sure. We are currently linearly interpolating them. Any thoughts @tjdcs?

We do have generation of CIE illuminant D series for arbitrary CCT, see the docstring here: https://colour.readthedocs.io/en/develop/generated/colour.sd_CIE_illuminant_D_series.html#colour.sd_CIE_illuminant_D_series

is not getting rendered on the website

I know, it sadly happened when we switched from a fully automated API documentation generation to a more manual one.

Cheers,

Thomas

tjdcs commented 5 months ago

I can take this issue at some point in the near future. It's relevant to my other work. @KelSolaar Can we please purchase the relevant standards? Or if we would prefer, I can access them via my other legal means. I just wouldn't be able to share them with the colour-maintenence team.

KelSolaar commented 5 months ago

Yes I have planned to purchase it! Will loop you in when it is done!