search

colour-science / colour

Colour Science for Python
https://www.colour-science.org
BSD 3-Clause "New" or "Revised" License
2.03k stars 257 forks source link

[BUG]: *Canon Cinema Gamut* uses D65 instead of D55 whitepoint. #1259

Closed MrLixm closed 2 months ago

MrLixm commented 2 months ago

Hey there,

issue

Definition of the Canon Cinema Gamut colorspace in colour specifies a D65 whitepoint while it seems the spec specifies a D55 whitepoint.

spec (as referenced and backup by colour): https://drive.google.com/file/d/1Vcz8RVIXgXL54lhZsOwGUjjVZRObZSc5/view

I am of course not 100% sure but it seems the ACES OCIO config also picked a D55 whitepoint.

module affected

https://github.com/colour-science/colour/blob/005fb748a3158301489404ab5b5489a43e5871c5/colour/models/rgb/datasets/canon_cinema_gamut.py#L54-L55

Let me know if this is an intended design. Best, Liam.

KelSolaar commented 2 months ago

At this point I cannot really say if it is a mistake or if Canon changed the whitepoint since I pulled the data originally in January 14, 2015 (ea1f6de8). This was a long time ago! At any rate, we should probably get that aligned with the current IDTs.

MrLixm commented 2 months ago

Great thanks !