search

colour-science / colour

Colour Science for Python
https://www.colour-science.org
BSD 3-Clause "New" or "Revised" License
2.03k stars 257 forks source link

[BUG]: Error in *Google Colab* `colour_how-to_guide.ipynb`. #1271

Closed javimixet closed 1 month ago

javimixet commented 1 month ago

Documentation Link

https://colab.research.google.com/notebook#fileId=1NRcdXSCshivkwoU2nieCvC3y14fx1X4X&offline=true&sandboxMode=true

Description

This part of the code doesn't work as expected:

gradient = colour.algebra.lerp(
    CAM16UCS[0][np.newaxis],
    CAM16UCS[1][np.newaxis],
    np.linspace(0, 1, 20)[..., np.newaxis])

Suggested Improvement

Should be like this instead:

gradient = colour.algebra.lerp(
    np.linspace(0, 1, steps)[..., np.newaxis],
    CAM16UCS[0][np.newaxis],
    CAM16UCS[1][np.newaxis])

Environment Information

No response

KelSolaar commented 1 month ago

Thanks a lot @javimixet! We changed colour.algebra.lerp signature a while ago but forgot to update the example. This should now be fixed!