colour-science / colour

Colour Science for Python
https://www.colour-science.org
BSD 3-Clause "New" or "Revised" License
2.03k stars 257 forks source link

Improve "OSA UCS" to "CIE XYZ" conversion. #759

Open KelSolaar opened 3 years ago

KelSolaar commented 3 years ago

Our optimization process does not do a good job with dark colours and actually fails miserably, we should revise our approach:

image image image

References

KelSolaar commented 3 years ago

I gave a stab at a Newton-Raphson minimizer as described by Moroney (2003): https://github.com/colour-science/colour/blob/feature/osa_ucs/colour/algebra/optimize.py

Good thing is that it is vectorised, so it is super fast! Problem is that it does also fail for dark colours:

image