search

colour-science / colour

Colour Science for Python
https://www.colour-science.org
BSD 3-Clause "New" or "Revised" License
2.11k stars 260 forks source link

Implement support for "Von Kries 2020" chromatic adaptation transform. #891

Open KelSolaar opened 2 years ago

KelSolaar commented 2 years ago

References

starkfan007 commented 2 years ago

Is this issue still active @KelSolaar ? If so, I hope to give a contribution for it. Thanks.

KelSolaar commented 2 years ago

Hi @starkfan007, yes it is still up!

starkfan007 commented 2 years ago

Hi @KelSolaar, I am a bit confused about some of the statements in the paper. The first question is how to understand the previous state and how to define the previous state in the code. I didn't understand this part very well. The second question is about D factor. There is no corresponding calculation formula in the paper. According to Table 1, D factor seems to be an empirical parameter adjusted through different model experiments. Thanks!

KelSolaar commented 2 years ago

Hello @starkfan007,

Sorry, I haven't had time to check the paper details yet! Let me get back to you!

tjdcs commented 2 years ago

I'm familiar with this paper. But it would be much easier for me to discuss on a call or voice chat. Feel free to reach out.