colouring-cities / colouring-britain

Developed out of the Colouring London prototype. Collecting data on Britain's buildings and testing new core features
https://colouringbritain.org/
GNU General Public License v3.0
10 stars 2 forks source link

Automatically hide Historical Map Layer when switching category. #158

Open mdsimpson42 opened 1 year ago

mdsimpson42 commented 1 year ago

When you turn on the historical maps, can we then turn them off automatically when we switch to a new category?

mdsimpson42 commented 1 year ago

My only question would be:

  1. Are there ever times when you would want to leave the historical map on when switching categories?
  2. What about displaying different data on the historical map?
polly64 commented 1 year ago

@mdsimpson42 no because you can see through it. If it was historical footprint outlines definitely yes but as it is a raster image of an historical Map there is no value. Also you can access it if you wish via the layers option on the interface

mdsimpson42 commented 1 year ago

I'm looking into this again.

Part of the problem is that everything else in this menu is an overlay that stays on when you switch categories. So its behaviour is technically consistent with the other layers. There isn't anything else we already turn off when you switch categories (as far as I can see?), and it would be weird (from a user experience perspective) if one layer resets and the others don't.

image

It's kind of its own separate thing. Not really a layer, like the others, but also not a separate category...

Should the historical maps be accessed differently? Maybe something that you can only turn on when you click the buttons in Age & History (not the above menu)? Or from a separate button, somewhere else on the interface... then it's less weird that it behaves differently?


I've tried a few things, but nothing that works consistently. I haven't yet found a piece of code that gets called when the category changes. I will come back to this later.

polly64 commented 9 months ago

also see #22