search

colouring-cities / colouring-britain

Developed out of the Colouring London prototype. Collecting data on Britain's buildings and testing new core features
https://colouringbritain.org/
GNU General Public License v3.0
10 stars 2 forks source link

Bug: URL validation in Team category #210

Open mdsimpson42 opened 1 year ago

mdsimpson42 commented 1 year ago

I've added multi-data-entry URLS to the team age (to replace the disabled free-text fields for landowner, designer, developer and builder names). They use the exact same code as the fields on other pages, but it doesn't check that the URL is valid before saving the data.

If, for example, I add source links to the address field on "Location", I get the following error message when I try to save data that is not a valid URL:

image

But in "Team", I can set the landowner links to be any free text (and it does not prompt "Please enter a URL"):

image

polly64 commented 1 year ago

@mdsimpson42 how best to resolve this one?

polly64 commented 8 months ago

@mdsimpson42 can we close?

mdsimpson42 commented 8 months ago

Still a bug. Haven't been able to work out why it isn't working - the code is identical, as far as I can see, to the code in other subcategories.

polly64 commented 7 months ago

@matkoniecz any thoughts on this?