colouring-cities / colouring-core

The Core Platform for the Colouring Cities Research Programme (CCRP)
https://colouringcities.org
GNU General Public License v3.0
48 stars 42 forks source link

Tuquoise highlight too thin to see #1053

Closed polly64 closed 1 year ago

polly64 commented 1 year ago

Hi @matkoniecz turquoise highlight v thin on my screen can we make a bit thicker?

Screenshot 2023-01-16 at 11 18 11
matkoniecz commented 1 year ago

I bet that something went wrong with supporting high-resolutions displays in highlight layer.

Will look into this.

https://github.com/colouring-cities/colouring-london/blob/master/app/src/frontend/map/layers/building-highlight-layer.tsx#L14

matkoniecz commented 1 year ago

Is it happening with all layers and all buildings? Or only with some?

On which computer it happens? (device model)

How it is supposed to look like:

screen

matkoniecz commented 1 year ago

https://leafletjs.com/reference.html

detectRetina If true and user is on a retina display, it will request four tiles of half the specified size and a bigger zoom level in place of one to utilize the high resolution.

and as outline is of a fixed size, it results in a smaller outline on retina displays, presumably removing it would result in expected size of outline but pixelated what would be unwanted but in a different way (I am guessing here that detectRetina matters, I will test it) ...

matkoniecz commented 1 year ago

@polly64 Is it currently a problem or not? (checking either live production site or staging will work)

polly64 commented 1 year ago

@matkoniecz fine for now thanks