Interface Tweaks

[mdsimpson42]

• [x] Location change building name(domestic ) to building name(residential)
• [x] Specific land use - in box can you edit to say ‘click here to see land use options? Or do you have to type something in – better if not
• [x] Specific land use- remove ID numbers from box Duplicate of colouring-cities/colouring-london#157
• [x] Change Type to Type & Form
• [x] Rename dynamic tissue classification – dynamic classification and move to bottom
• [x] colouring-cities/colouring-london#110
• [x] Under ‘Age’ Move Architectural style/Historical period to top
• [x] Under Street Change under green space: to ‘Does this building contain flats and have a dedicated green space?’
• [x] Planning. Change subcategory title ‘land ownership’ to ‘Land ownership type’
• [x] Team- change ‘land ownership’ subtitle to ‘land owner at time of construction’
• [x] Add ‘official’ environmental quality rating to energy performance section
• [x] 13 remove double residential energy rating
• [x] Are there any () irregularities in the shape of the building- remove ‘structural ‘
• [x] Check all info button and remove any that are repeats of questions e.g on construction
• [x] Location – make non residential into a link and remove the name link
• [x] Street Context: Does the building have aback/front garden with greenery?
• [x] Location add ‘open in front of building ID, Unique property ref etc
• [x] Open Longitude building centroid coordinate
• [x] Resilience section: Building damage assessment tool- change to ‘Disaster management tool
• [x] @mdsimpson42 Rename subvisions in 'Location : Property addresses; Building Subvision; Open property IDs & Open Building footprint IDs; Open centroid coordinates for buildings
• [x] as a priority could you restore listed buildings thanks they have got lost
• [x] source type/links on energy performance (environmental & energy ratings)

TODO:

• [x] If a building has a Listed Grade in the database, set "is it listed" to yes and ensure link is created to ID

[mdsimpson42]

With "Location – make non-residential into a link and remove the name link": We're showing the residential and non-residential name of the property, but we also know whether the property is classified as residential or non-residential (from Land Use). Could we show whether the building is residential or non-residential, and then only display the relevant name fields? (And display both fields if the property's land use type is "mixed" or unknown?)

[mdsimpson42]

Many tooltips had duplicated text from the question/label on the field. There were also some erroneous tooltips, mostly copy-paste errors from other fields. I believe most of these have now been removed.

[mdsimpson42]

Some of these items have been ticked off because they were addressed by adding new issues.

[polly64]

@mdsimpson42 Could you also keep on the list for moment unticked as much easier for me to keep track of and talk to you about - could you put the issue link next to them if they have one and tick this only if completed thanks

[polly64]

@mdsimpson42 could you release any changes today so they are there for Monday. Any luck with listed buildings realise I need for meeting on 14th?

[mdsimpson42]

@mdsimpson42 Could you also keep on the list for moment unticked as much easier for me to keep track of and talk to you about - could you put the issue link next to them if they have one and tick this only if completed thanks

No. I will close this issue when I have addressed all of the current tasks in it. The unfinished tasks can be tracked in separate issues. The Project Board is the best place to keep track of which tasks are in progress, completed and deployed. The Land Use IDs task is on the Need Help list. The terrace/row task is on the Blocked list (I cannot address this right away because of the database changes required). If anything else comes up, they will need to go into a new issue, rather than continuing to edit this one. It's impossible to keep track if new tasks keep popping up on issues that I think are complete.

@mdsimpson42 could you release any changes today so they are there for Monday. Any luck with listed buildings realise I need for meeting on 14th?

I can deploy what I have to Staging by the end of the day, but at this rate it might not be everything on this list. I'm not deploying incomplete or untested code to Production.

[mdsimpson42]

I can't find Listed Status anywhere in the code, so I've added it. There is a new question under "Heritage assets and building protection" in Planning that says: "Is the building listed?" and under that, it asks for the Grade and ID (fields which existed in the code but weren't on the interface).

At some point, we should move this out of Core and into Colouring London (see This Issue), but for now it was easier to work with what was there.

(What is the difference between this and the "locally listed heritage asset" that we added?)

[mdsimpson42]

The current changes are deployed to Staging.

Note: You may have to select "yes" under "is this a listed building?" before you can see the Grade/ID selectors.

• [ ] I will try and add something to the database script to fill this in automatically if other data has been entered, but I've ran out of time for now.

[polly64]

hi @matkoniecz the listed building code you created where you also entered all the IDs seems to have got lost. We want to show this next week, is there any way you could see if you could reinstall it?

[matkoniecz]

it seems to work?

[polly64]

hi @matkoniecz the listed building code you created where you also entered all the IDs seems to have got lost. We want to show this next week, is there any way you could see if you could reinstall it?

thanks v much @matkoniecz but are you able to see this on Colouring London? I can't see it

[matkoniecz]

@mdsimpson42 Is it safe to restore older version on the deployed site? Or would it break something else that is important?

[matkoniecz]

@polly64

looking at it now it seems to work (it fails if you put letters in the id, are there ids with letters in them rather numbers?)

[mdsimpson42]

Sorry for the confusion. Tom as able to suggest which change to the code apparently removed this feature back in July. There were a lot of changes made at the time so it's hard to see exactly how it was removed (or to remember why). The data and backend code was all still there, it just dropped off the interface, possibly when chances were merged from Core to London. It may have been an accident or it may have been deliberate; I have a vague recollection of trying to rename things so they weren't so UK-specific, but that doesn't explain why it disappeared altogether.

I'm planning to close this issue for now (in the next couple of days). The fix has been deployed to production ahead of the meeting/demo today. If there are any changes we want to make to these behaviours, we can create a new issue to keep track of them.