Closed matkoniecz closed 2 years ago
Decision from meeting: replace "Is locally listed?" boolean data with fake link like http://please-replace-with-real-link
( by @polly64 )
Do the same with other boolean data (if present)
notes from meeting:
"Is the building on the National Heritage List for England?" / "NHLE list entry link" - planning_nhle_link
- no data stored, changing data format without migrating data
"In an Architectural Priority Area?" [SIC!] "Archaeological Priority Area" - planning_in_apa
- just removed as empty and invalid
"World heritage list id" planning_world_list_id
- if set, then convert = maybe even manually
"Heritage at risk list id" - planning_heritage_at_risk_id
if set then convert to links
"In a conservation area?" planning_in_conservation_area
- if set then convert to fake links
"National Heritage List for England list id" planning_list_id -> convert into links like https://historicengland.org.uk/listing/the-list/list-entry/1080446?section=official-list-entry
"In the Greater London Historic Environment Record?" planning_in_glher - just delete all of that because it is alway set to "false", so no useful info
"Architectural Priority Area tier" planning_apa_tier - just remove as empty and invalid "Architectural Priority Area name" planning_apa_name - just remove as empty and invalid
partially done, partially replaced by https://github.com/colouring-cities/colouring-london/issues/925#issuecomment-1252458663 redesign issue
"National Heritage List for England list type" planning_list_cat
- also cleared for deletion (was imported, can be reimported)
Removed code
```"National Heritage List for England list id" and "National Heritage List for England list type" should be removed and @polly64 will decide on further actions (return them or remove also backing code)