colouring-cities / colouring-core

The Core Platform for the Colouring Cities Research Programme (CCRP)
https://colouringcities.org
GNU General Public License v3.0
48 stars 43 forks source link

IDs for planing #938

Closed polly64 closed 2 years ago

polly64 commented 2 years ago

Describe the solution A clear and concise description of what you want to happen.

Describe any alternatives A clear and concise description of any alternative solutions or features you've considered.

Additional context Other context or background information.

matkoniecz commented 2 years ago

https://cl-staging.uksouth.cloudapp.azure.com/edit/planning/2956004 - can you simply give example of links that user would put as answer, in currently deployed staging version?

for "Is the building on the National Heritage List for England?" it could be https://historicengland.org.uk/listing/the-list/list-entry/1080446?section=official-list-entry

polly64 commented 2 years ago

@matkoniecz have just written to HE with queries and will add whatever links I can now but some are problematic

polly64 commented 2 years ago

@matkoniecz still saying database error when i add NHLE link.

matkoniecz commented 2 years ago

will add whatever links I can now

Great!

but some are problematic

In which way? Is there is no id? Is there is no possibility to provide link at all? Something else? have a look at email i sent to Historic england just now which explains what we need from them and let me know if anything unclear

when i add NHLE link.

should work now

yes works now

i am adding for house of parliament looking for APA now

polly64 commented 2 years ago

@matkoniecz comemnts above

polly64 commented 2 years ago

@matkoniecz - I.m actually not sure we are going to be able to get IDs or links for heritage assessment or the Historic environment record - I can't seem to find any but we can wait for HE response

polly64 commented 2 years ago

@matkoniecz so I think we are going to have to pause on some of this while we wait for HE. But we should still prioristise

Go through all GitHub issues and close ones completed so we can see what outstanding

matkoniecz commented 2 years ago

@polly64

reorder as https://github.com/colouring-cities/colouring-london/issues/939

Done, I think (please look at staging or https://github.com/colouring-cities/colouring-london/issues/939#issuecomment-1256641868 is it what you expected - or is more that reorder needed)

do the ID links just for Listed buildings and WHS.

So for WHS link like https://whc.unesco.org/en/list/488 is expected, right? (you can see how it works on staging)

For APAs and locally listed buildings we just need to be able to add PDF links for the moment.

So no change needed, from the current amorphous link input?

For CAs there is an ID and there are PDF appraisal docs for each conservation area which will contain multiple buildings.

So introduce id field and keep link input? Or do not make changes and keep as is right now with link input?

polly64 commented 2 years ago

@matkoniecz

reorder as #939

Done, I think (please look at staging or #939 (comment) is it what you expected - or is more that reorder needed)

yes thanks

do the ID links just for Listed buildings and WHS.

yes for the moment

So for WHS link like https://whc.unesco.org/en/list/488 is expected, right? (you can see how it works on staging)

yes this looks v good

For APAs and locally listed buildings we just need to be able to add PDF links for the moment.

So no change needed, from the current amorphous link input?

I think we should be explicit as to what they have to do and say in each box 'Please add relevant link here'

For CAs there is an ID and there are PDF appraisal docs for each conservation area which will contain multiple buildings.

So introduce id field and keep link input? Or do not make changes and keep as is right now with link input?

So yes have ID field but we can't connect this to a set link so we have to have a link box which has ' Please add CA appraisal link here' written in it

Also please add (CA) after 'conservation area' in question if you think isn't obvious what CA refers to

PS I personal think the please is probably important as if you say 'Add this here' compared to 'please add this here' the second implies that you are requesting engagement for which you are grateful and the first sounds both a bit bossy but also like just like an impersonal instruction of what to do how. What do you think?

matkoniecz commented 2 years ago

I think we should be explicit as to what they have to do and say in each box 'Please add relevant link here'

Changing https://... to Please add relevant link here then

PS I personal think the please is probably important as if you say 'Add this here' compared to 'please add this here' the second implies that you are requesting engagement for which you are grateful and the first sounds both a bit bossy but also like just like an impersonal instruction of what to do how. What do you think?

I agree, and if there is enough space to fit it, then it is better to include also "please"

So yes have ID field but we can't connect this to a set link so we have to have a link box which has ' Please add CA appraisal link here' written in it

Also please add (CA) after 'conservation area' in question if you think isn't obvious what CA refers to

So this one remains as the remaining segment, with everything else done (https://... to Please add relevant link here change is not yet deployed).

polly64 commented 2 years ago

@matkoniecz ok great- let me know when you want me to check things on staging. I also have a meeting with Mike at 12 noon if we want to look at/discuss any pull requests. I can also answer any questions til then

matkoniecz commented 2 years ago

@polly64 Is this data display fine?

screen09

matkoniecz commented 2 years ago

@polly64 Should CA in the first hint text be expanded to the full "Conservation Area" name?

polly64 commented 2 years ago

@matkoniecz looks good but think maybe clearer if we use 'ID' rather than 'identifier. Can u also see if there's a way of linking to the 'like me' map on , community rather than the expected application map

matkoniecz commented 2 years ago

was done by #946