colstrom / gitinspector

Automatically exported from code.google.com/p/gitinspector
GNU General Public License v3.0
0 stars 0 forks source link

gitinspector --metrics errs out on paths with spaces #47

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
> What steps will reproduce the problem?
1. have a git repo with spaces in its paths
2. invoke gitinspector.py --metrics /path/to/repo

> What is the expected output? What do you see instead?
The normal output of --metrics. I see instead:
fatal: Path 'other' does not exist in 'HEAD'
fatal: Path 'files/go_here' does not exist in 'HEAD'

> What version of the product are you using?
0.3.2

> What version of Python?
Python 2.7.8

> On what operating system?
Linux Debian/sid

Patch shows the necessary diff to make it handle "other files/go_here".

Original issue reported on code.google.com by virg...@gmail.com on 17 Nov 2014 at 10:44

Attachments:

GoogleCodeExporter commented 9 years ago
Hi. Gitinspector will be able to handle multiple repositories at some point 
(and group them together). What you are seeing doesn't really relate to 
gitinspector - it's related to the terminal. If you want to pass something as 
one path when invoking gitinspector from the terminal, just do the following:

gitinspector.py --metrics "/other files/go_here"

Also, This patch would break terminals that don't use '"' to group arguments 
together.

/Adam Waldenberg

Original comment by gitinspe...@ejwa.se on 19 Nov 2014 at 6:19

GoogleCodeExporter commented 9 years ago
I agree the problem is with the terminal.
However, it's not the /path/to/repo that contains spaces.
It's files inside that repo (that have spaces in their filename) that break 
gitinspector.py

Therefore I think it's a very valid bug :-)

Original comment by virg...@gmail.com on 20 Nov 2014 at 8:11

GoogleCodeExporter commented 9 years ago
Aha. That makes more sense... Sorry.

I'm actually doing something similar in blame.py and it seems to be working for 
most users (and terminals ;)).

/Adam Waldeneberg

Original comment by gitinspe...@ejwa.se on 21 Nov 2014 at 1:45

GoogleCodeExporter commented 9 years ago
This issue was closed by revision dd50994f2c4c.

Original comment by gitinspe...@ejwa.se on 21 Nov 2014 at 1:56

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Issue 56 has been merged into this issue.

Original comment by gitinspe...@ejwa.se on 9 Feb 2015 at 4:53