search

colszowka / phantomjs-gem

Phantomjs via Rubygems: Auto-install phantomjs on demand for current platform. Comes with poltergeist integration.
Other
222 stars 104 forks source link

Make poltergeist dependency optional #13

Closed bjeanes closed 11 years ago

bjeanes commented 11 years ago

Poltergeist is only needed in certain scenarios. Unfortunately, whether or not it is being used, one has to pay the cost of its entire dependency tree (which is quite large!).

Ideally, this would not be a hard dependency.

colszowka commented 11 years ago

Yes, that should be changed, but this is a duplicate of #10.

bjeanes commented 11 years ago

I added a commit to this that fixes it, but GH seems to be ignoring changes to my branch and is instead only showing d187b59 which is a broken commit. f8f79e8 on my fork fixes this issue. I think this PR is mis-behaving because it is closed, so I'll simply re-open a new one.