search

colszowka / phantomjs-gem

Phantomjs via Rubygems: Auto-install phantomjs on demand for current platform. Comes with poltergeist integration.
Other
222 stars 104 forks source link

Support phantomjs 2.0 #54

Closed gfrivolt closed 8 years ago

gfrivolt commented 9 years ago

I tried to upgrade to phantomJs 2.0 here https://github.com/netronixgroup/phantomjs-gem/tree/upgrade-to-2.0.0.

Several specs fail, I'm not familiar with the codebase. Can you help to upgrade it to support 2.0?

mtyeh411 commented 9 years ago

+1

ponchik commented 9 years ago

+1

jeffnappi commented 9 years ago

+1

mikeb-iacquire commented 9 years ago

+1

nanernunes commented 9 years ago

+1

jeffnappi commented 9 years ago

Looks like this will have to wait until PhantomJS themselves get the static Linux binaries working. See https://github.com/ariya/phantomjs/issues/12948

swistaczek commented 9 years ago

+1

karlingen commented 9 years ago

+1

mgrachev commented 9 years ago

+1

edenvicary commented 9 years ago

:+1:

dmitry commented 9 years ago

https://github.com/gitromand/phantomjs/releases - available phantomjs-2.0.1-development-linux-x86_64.zip

betelgeuse commented 9 years ago

@dmitry I don't think this gem should use binaries not sanctioned by upstream (you linked to a forked repo).

dmitry commented 9 years ago

@betelgeuse thank you for noticing that. Lets wait till the upstream binaries will appear.

meghan-mcqueeney commented 9 years ago

+1

dmitry commented 9 years ago

Guys, just to understand: what means +1?

Is it's something like:

please implement, but I cannot help you anyhow"

Or there are some other meaning of such comments?

PS. As I understand, currently it's not possible, as there are no binaries released yet.

betelgeuse commented 9 years ago

@dmitry It's like Facebook like or the vote functionality in bugzilla. Since Github does not have native support for it, many people have taken to using +1 to signal importance. I am not sure what my personal opinion on such comments is given the current Github feature set.

kuraga commented 8 years ago

+1

pivotal-rivals commented 8 years ago

The main PhantomJS repo builds its binaries from the deploy page page for both Linux and Mac OSX. They have prebuilt it for Mac on their download page. For Linux, but have one remaining issue 12948.

montulli commented 8 years ago

+1

sashee commented 8 years ago

The official 2.1.1 version is out, with official Linux binaries.

colszowka commented 8 years ago

Finally, excellent! Would you mind sending in a PR with the updated urls?

On Mon, Jan 25, 2016 at 1:13 PM -0800, "Tamás Sallai" notifications@github.com wrote:

The official 2.1.1 version is out, with official Linux binaries.

— Reply to this email directly or view it on GitHub.

sashee commented 8 years ago

Yep, just opened #66 .

BrianHawley commented 8 years ago

Please close this in favor of #66.

mgrachev commented 8 years ago

We need a new release 2.1.1.0 on rubygems

colszowka commented 8 years ago

@mgrachev The build on travis CI was failing, it is now fixed with #68 - I will ship the new release in a few minutes.

mgrachev commented 8 years ago

@colszowka Thanks!