Allow download host to be configurable

colszowka / phantomjs-gem

Phantomjs via Rubygems: Auto-install phantomjs on demand for current platform. Comes with poltergeist integration.

Other

222 stars 106 forks source link

Allow download host to be configurable #73

Closed chrisledet closed 8 years ago

chrisledet commented 8 years ago

First looking for the env var PHANTOMJS_CDNURL to determine where the binary files should be pulled from. If not given, it will fallback to previously site Bitbucket.

The npm package phantomjs-prebuilt which provides similar functionality with that same environment variable so I went with it.

chrisledet commented 8 years ago

As I mentioned in #72 I have another patch for v1.9.x. Just need some clarity.