colszowka / phantomjs-gem

Phantomjs via Rubygems: Auto-install phantomjs on demand for current platform. Comes with poltergeist integration.
Other
222 stars 106 forks source link

Give it some love #74

Closed deivid-rodriguez closed 8 years ago

deivid-rodriguez commented 8 years ago

Hi!

I tried the gem and it didn't work for me in linux, since I had not set either ENV['TMPDIR'] nor ENV['TEMP'] nor my user had permissions to write to /tmp. See https://github.com/colszowka/phantomjs-gem/blob/c4b1e2b872212c26639711975678b23f96d53e24/lib/phantomjs/platform.rb#L12-L14.

So I changed it to instead download it to a temp folder in the install location.

Then I run the tests and took the chance to add some other improvements.

Let me know what you think!

deivid-rodriguez commented 8 years ago

Ping