search

colszowka / phantomjs-gem

Phantomjs via Rubygems: Auto-install phantomjs on demand for current platform. Comes with poltergeist integration.
Other
222 stars 104 forks source link

Allow overriding download url by environment variable #78

Closed werkshy closed 4 years ago

werkshy commented 8 years ago

Easy workaround for bitbucket ratelimiting issues. Upload the phantom binaries to your own S3 folder (and make them public) then set this environment variable:

PHANTOM_DOWNLOAD_URL_BASE=https://s3.amazonaws.com/your.bucket.name.here

Addresses #70.

werkshy commented 8 years ago

The Travis build failed because of bitbucket rate limiting, which is exactly what I am trying to workaround here ¯(ツ)/¯

adragoset commented 8 years ago

This would be a welcome addition. Im running into the exact same problem and am trying to decide if i need to fork this repo and host it on my own gem server to solve this problem.

jamilbk commented 8 years ago

Running into the same problem here, as are quite a number of CI users it seems. I forked and started hacking on this only to find this PR lingering around. @colszowka any thoughts on getting this merged in?

atambo commented 8 years ago

@colszowka Any change you can merge this? This should allow people to workaround #70.

werkshy commented 4 years ago

I am just closing old PRs of mine.