colszowka / phantomjs-gem

Phantomjs via Rubygems: Auto-install phantomjs on demand for current platform. Comes with poltergeist integration.
Other
222 stars 104 forks source link

Silence which output to STDOUT #83

Open ArnisL opened 8 years ago

ArnisL commented 8 years ago

Unsure how good/bad idea this is

But at least locally I've made these changes:

      def system_phantomjs_path
        #`which phantomjs`.delete("\n")
        (system 'which phantomjs', STDOUT: '/dev/null').delete("\n")
      rescue
      end

Maybe others find this a good idea

mokoaki commented 8 years ago

+1

tuxayo commented 7 years ago

See #85 for a pull request that would close this.