search

colszowka / phantomjs-gem

Phantomjs via Rubygems: Auto-install phantomjs on demand for current platform. Comes with poltergeist integration.
Other
222 stars 104 forks source link

Build for 2.5.0-beta? #97

Closed ashawley closed 6 years ago

ashawley commented 7 years ago

PhantomJS 2.5.0-beta was released earlier this year and works ok for me on a mac. I haven't tested it anywhere else.

It's worth getting this beta in more people's hands, IMO, to support upstream development. Would it be possible to just push a beta version to rubygems.org for now? I'm not suggesting this get merged to master. Maybe just make a 2.5 branch for now?

Despite the news that the current PhantomJS maintainer left to work on a headless Web development tool targeting Chromium, there is a lot of work and improvements in PhantomJS 2.5.0. The pre-releases should start getting exposed in hopes of improving the chance of a stable release.

Thanks for phantomjs-gem!

ashawley commented 7 years ago

Well it builds in Ubuntu trusty, so that's good!

victorhazbun commented 7 years ago

I'm getting this when running my test. SpeakEZ:2.5.0-beta

Cliver::Dependency::VersionMismatch:
  Could not find an executable '/Users/victor/.phantomjs/2.5.0.beta/darwin/bin/phantomjs' that matched the requirements '>= 1.8.1', '< 3.0'. Found versions were {"/Users/victor/.phantomjs/2.5.0.beta/darwin/bin/phantomjs"=>"6.dylib"}

I am doing something wrong?

ashawley commented 7 years ago

@victorhazbun Were you able to resolve your issue?

ashawley commented 6 years ago

Seems 2.5 release is postponed. Closing.

waterjump commented 6 years ago

@victorhazbun:

I had this issue and was able to resolve it by following the instructions here: https://rtmccormick.com/2017/03/19/solved-phantomjs-2-5-libwebp-6-dylib/