search

coltondick / nordic-theme-main

Nordic theme for home assistant.
Apache License 2.0
10 stars 2 forks source link

1.2 colors are less than ideal #6

Open jonathanjsimon opened 1 month ago

jonathanjsimon commented 1 month ago

The swapped background color for the standard theme under 1.2 is quite jarring

coltondick commented 1 month ago

Does 1.2b resolve this issue? If not, can you provide me with a screenshot of what you're seeing?

jonathanjsimon commented 1 month ago

1.2b is visually the same for me. FWIW, under 1.2+ it seems that this darker background is only applied to dashboards but not to HA pages like the Energy pane, the HACS pane, or any of the settings panes

1.2(b): Screenshot_20240606_132952

1.1: Screenshot_20240606_133150

coltondick commented 1 month ago

Is there a chance that you haven't set the correct theme in your profile settings? I'm unfortunately unable to recreate this issue on my current Home Assistant instance. Give me a bit here to test it out on a fresh installation.

jonathanjsimon commented 1 month ago

Well, it's been working since I started using the theme. But I just updated back to 1.2b, refreshed, went to my profile, selected some other theme, refreshed, selected the Nordic theme, refreshed, manually toggled to Light mode, refreshed, then back to Auto with the same result. I also cleared my browser's cache (just files, kept cookies etc) without any effect.

Thank you for looking into it

coltondick commented 1 month ago

Interesting... I've just setup a fresh installation of Home Assistant, installed HACS, installed this theme, went to my profile and set the theme to "Nordic" and the theme is applied correctly across the entire interface.

I have had some recent contributions from @codavs65r, but I don't see anything that would cause the background color to be set to black.

@codavs65r does the theme work for you as expected, or are you noticing the same thing as @jonathanjsimon?

codavs65r commented 1 month ago

I cannot reproduce the issue. The theme is working as expected. @jonathanjsimon, what is your browser ? How the other themes work ?

jonathanjsimon commented 1 month ago

It reproduces everywhere I try it but my browser is Brave. It also happens in the official HA Android app.

I went and installed the noctis theme and it functions as it should as does the default HA theme. I tried several others and they all seem to work as intended. I'll note that I went through several of the most starred and most recently updated theme packs trying to find one that had both a light and dark theme in the same way as this theme without success.

Correction: The Material Rounded theme has the light/dark modes and it works correctly although its background may just be the same as the default background such that I cannot tell the difference.

coltondick commented 1 month ago

I'll continue to do some testing to see if I can reproduce the issue. I'll do some testing with the HA Android app as well.

coltondick commented 1 month ago

Do you by chance have a separate theme configured under the view? If you go to your dashboard, edit it, on the current tab click the pencil to edit the view. Ensure it's set to no theme.

image Google Dark Theme is set currently.

image No theme is set.

coltondick commented 1 month ago

Can you also test if the issue persists if you open HA in a new private window in Brave?

jonathanjsimon commented 1 month ago

It does. One additional thing I notice there is that the default HA generated/managed Overview does not have this problem while all my dashboards that I made myself do. They are all UI managed not yaml backed.

jonathanjsimon commented 1 month ago

Lol, I came to comment on the dashboard specific theme thing and see I missed an earlier comment about it. All of mine have "No Theme" selected, which should default to global theme. But it doesn't only if Nordic is selected as the global. If I select No Theme explicitely and save, that dashboard is now themed properly.

The1nonly1 commented 1 month ago

Issue still exists for me after the 1.2b update across mobile (android) and PC (Chrome and Firefox, with both normal and incognito). I only have the theme selected on profile and not on any view on a dashboard. However, as a test, I changed the theme to Nordic on one view and it fixed it but I then changed it back to no theme and made sure the code was deleted and it fixed the issue on that one view.