coltoneshaw / 3cpm

The 3C Portfolio Manager is an essential addon to your 3Commas experience. It enables you to manage your DCA bots with greater analytics, real-time alerting, and tons of additional features.
GNU General Public License v3.0
120 stars 21 forks source link

v2.0.1 #126

Closed coltoneshaw closed 2 years ago

coltoneshaw commented 2 years ago

Fixing bug with 3C API

bgratt commented 2 years ago

@coltoneshaw Thanks for fixing the bug. I downloaded the latest version (Mac edition) and installed it. Then I created a fresh pair of API keys and connected them. Now I don't see the error anymore. However, seems the data is not properly getting fetched as the Active Deals section remains empty + some sections inside Stats.

I tried resetting the profile and even deleting it and starting again, but the issue remains the same. Any thoughts?

mfread commented 2 years ago

Thanks for fixing the missing data field issue @Colton.

Downloaded 2.0.1. Ran installer exe (presumably it over-writes my previous 2.0.0 install). 3CPM started. No active deals shown.

Went to setup. Tested API (not a new API - the one I was using with 2.0.0). No errors (in fact, no msgs at all - should there be? I can't recall) but General->Enabled switched to 'off' position when I tested the API. Enabled the setting and clicked on Save Profile. Tried to refresh active deals screen - nada. Deleted cache and retried - nada. Forced refresh - nada.

Went to Console. Found this:

react.development.js:220 Warning: Each child in a list should have a unique "key" prop.

Check the render method of `CustomTable`. See https://reactjs.org/link/warning-keys for more information.
    at div
    at CustomTable (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:476076:24)
    at div
    at DealsTable (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:478726:23)
    at div
    at ActiveDealsPage (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:478639:81)
    at Route (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:431161:29)
    at div
    at MainWindow (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:480996:59)
    at div
    at Router (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:430792:30)
    at HashRouter (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:430454:35)
    at App (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:482635:60)
    at ThemeEngine (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:476894:24)
    at Provider (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:428121:20)
    at LocalizationProvider (file:///C:/Users/Mark/AppData/Local/Programs/3c-portfolio-manager/resources/app.asar/dist/renderer.js:243899:5)

What do I try next? Un-install then re-install?

Cheers, Mark

mfread commented 2 years ago

Un-installed & re-installed. Same issue as above (no active deals showing).

coltoneshaw commented 2 years ago

Odd. Can someone try menu > help > reset profile. Then sync again? My test had it but it was a fresh database. I’ll get another fix out this morning if that’s the fix

bgratt commented 2 years ago

I tried that as well, but still it's the same result.

coltoneshaw commented 2 years ago

Perfect, thanks. Working to see what the issue is right now.

mfread commented 2 years ago

Downloaded and installed 2.0.2 on Win10. Working now thanks Colton. Time to buy you a coffee I think :)

I'll keep a watch on it.

coltoneshaw commented 2 years ago

Fantastic!! Be on the lookout for more. A lot incoming hopefully 😉

bgratt commented 2 years ago

Yes, its working again. Thanks for all your efforts @coltoneshaw.