MIDI does not meet magma standards

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
ran .mid of pro of immigrant song through magma for QA

What is the expected output? What do you see instead?
lots more mid errors than expected.  worth looking at. 

Please provide any additional information below.

http://keepitfishy.com/customscreator/pikminguts92/Misc/magma_pro_immigrantsong.
txt

Original issue reported on code.google.com by columbo...@gmail.com on 17 Apr 2013 at 6:58

Attachments:

[mid errors.txt](https://storage.googleapis.com/google-code-attachments/ziggy-pro-editor/issue-43/comment-0/mid errors.txt)
[Immigrant Song.rar](https://storage.googleapis.com/google-code-attachments/ziggy-pro-editor/issue-43/comment-0/Immigrant Song.rar)

GoogleCodeExporter commented 9 years ago

First easy bug: the first measure is M1, not M0.

Here's a specific spot where Ziggy's starts losing beats in Son of a Preacher 
Man:

M8.1 in reaper vs. M7.1 in Ziggy's: Ziggy's shows 3 beats instead of 4 for the 
measure. Over the whole song it adds up to a lost measure.

In REAPER:
M8.1 is a new bpm of 90.232
M9.1 is a new bpm of 90.344
etc

Original comment by columbo...@gmail.com on 19 Apr 2013 at 1:55

GoogleCodeExporter commented 9 years ago

Running v62 through Magma, then through EOF, then through Magma again for midi 
testing.

If looks like the double-notes bug from v61 is now resolved.  But the No root 
note for gen bug is still there.

Saving unsaved changes before build.
Build started at 12:15 PM.
Reading the archive
SystemInit Params: C:\Program Files\Harmonix Music Systems\Magma 
v2\MagmaCompiler.exe -have_lock F:\RBN Authoring\Pro 
Guitar\Nyxyxylyth\elo_dontbringmedown\dontbringmedown.rbproj F:\RBN 
Authoring\Pro Guitar\Nyxyxylyth\elo_dontbringmedown\dontbringmedown.rba -mutex 
HMX_Magma_736419215355112235181
Project Compiler: Reading project 'F:\RBN Authoring\Pro 
Guitar\Nyxyxylyth\elo_dontbringmedown\dontbringmedown.rbproj'...
Project Compiler: Entering Phase 1 of 5...
Metadata Compiler: Starting...
Metadata Compiler: Done.
Project Compiler: Entering Phase 2 of 5...
MIDI Compiler: Starting...

ERROR: MIDI Compiler: f:/rbn authoring/pro 
guitar/nyxyxylyth/elo_dontbringmedown/dontbringmedown.mid (PART REAL_GUITAR): 
No root note set for gem at 18:2:237

[many lines deleted]

ERROR: MIDI Compiler: f:/rbn authoring/pro 
guitar/nyxyxylyth/elo_dontbringmedown/dontbringmedown.mid (PART REAL_GUITAR): 
No root note set for gem at 116:3:000

ERROR: MIDI Compiler: (PART REAL_BASS): Overdrive phrase at [27:1:000] has no 
gems in easy difficulty
ERROR: MIDI Compiler: (PART REAL_BASS): Overdrive phrase at [36:1:000] has no 
gems in easy difficulty
ERROR: MIDI Compiler: (PART REAL_GUITAR): Overdrive phrase at [67:1:000] has no 
gems in easy difficulty
ERROR: MIDI Compiler: (PART REAL_BASS): Overdrive phrase at [68:1:000] has no 
gems in easy difficulty

running the midi through EOF (which sets root notes) and retesting:

    Saving unsaved changes before build.
    Build started at 12:35 PM.
    Reading the archive
    SystemInit Params: C:\Program Files\Harmonix Music Systems\Magma v2\MagmaCompiler.exe -have_lock F:\RBN Authoring\Pro Guitar\Nyxyxylyth\elo_dontbringmedown\dontbringmedown2.rbproj F:\RBN Authoring\Pro Guitar\Nyxyxylyth\elo_dontbringmedown\dontbringmedown.rba -mutex HMX_Magma_42119141811215622230
    Project Compiler: Reading project 'F:\RBN Authoring\Pro Guitar\Nyxyxylyth\elo_dontbringmedown\dontbringmedown2.rbproj'...
    Project Compiler: Entering Phase 1 of 5...
    Metadata Compiler: Starting...
    Metadata Compiler: Done.
    Project Compiler: Entering Phase 2 of 5...
    MIDI Compiler: Starting...

    ERROR: MIDI Compiler: (PART REAL_GUITAR): Cannot parse event 0xf0 at [26:4:240]

    ERROR: MIDI Compiler: (MIDI FILE): Overdrive phrase at [36:1:000-37:1:000] for guitar but not real_guitar
    ERROR: MIDI Compiler: (MIDI FILE): Overdrive phrase at [47:3:240-49:1:000] for guitar but not real_guitar
    ERROR: MIDI Compiler: (MIDI FILE): Overdrive phrase at [55:3:240-57:3:000] for guitar but not real_guitar
    ERROR: MIDI Compiler: (MIDI FILE): Overdrive phrase at [67:1:000-68:1:000] for guitar but not real_guitar
    ERROR: MIDI Compiler: (MIDI FILE): Overdrive phrase at [84:3:000-85:3:000] for guitar but not real_guitar
    ERROR: MIDI Compiler: (MIDI FILE): Overdrive phrase at [96:3:240-97:3:240] for guitar but not real_guitar
    ERROR: MIDI Compiler: (MIDI FILE): Overdrive phrase at [104:3:240-105:3:240] for guitar but not real_guitar
    MIDI Compiler: Done.
    ERROR: Project Compiler: Midi compiler failed.
    Build ended at 12:35 PM.

author note:
After deleting the syntax events, Magma showed me that you're missing notes for 
some of the lower difficulties during overdrive phrases. That's a big no-no in 
authoring standards.

Original comment by columbo...@gmail.com on 27 May 2013 at 5:36

GoogleCodeExporter commented 9 years ago

note: I see a location in the 5 button (in easy) where the overdrive has no 
notes, thus propagating the problem to pro.

I can not find the parse event fail in the editor, I'll ask for more details 
from PG.

Original comment by columbo...@gmail.com on 27 May 2013 at 5:48

GoogleCodeExporter commented 9 years ago

One thing to note, the only reason EOF would be writing Sysex events in the pro 
guitar tracks is for backwards compatibility with Phase Shift.  They are used 
to mark pro guitar slides (and some non Rock Band notations palm muting and 
vibrato), but are only included in notes.mid and not the notes_pro.mid file, 
which is meant to be fully Rock Band compatible.

Original comment by raynebc on 27 May 2013 at 7:32

GoogleCodeExporter commented 9 years ago

based on discussions, we are only chasing these type errors:

ERROR: MIDI Compiler: f:/rbn authoring/pro 
guitar/nyxyxylyth/elo_dontbringmedown/dontbringmedown.mid (PART REAL_GUITAR): 
No root note set for gem at 18:2:237

as the others can be explained in the specific song and are not editor issues. 

Can someone very intimate with EoF (hint) perhaps explicitly spell out the 
required last step here at the finish line?

Original comment by columbo...@gmail.com on 28 May 2013 at 1:13

GoogleCodeExporter commented 9 years ago

The root notes just need to be written as described in issue 27.  You can 
examine any official RB3 MIDIs or those produced by EOF for examples of how 
they are written (basically the same way as any other marker).

Original comment by raynebc on 29 May 2013 at 7:42

GoogleCodeExporter commented 9 years ago

ok, so If I have to set a root note for each note/gem?  Here is an example:

A barre chord (fret 5).  So I chart the note.  Now, I have to set a root note 
and that means a midi-note of 9 (at the same note position/time as the A barre 
chord).

In EoF are you extrapolating that 9 based on the fact that the top most string 
is at position 5 and thus an A root, or do you ask the charted to denote each 
and every root?

Original comment by columbo...@gmail.com on 30 May 2013 at 6:44

GoogleCodeExporter commented 9 years ago

Traditionally, I think the scale a chord is in is determined by its root note, 
but EOF's chord lookup formally compares each chord against chord formulas in 
each of the 12 musical scales, even allowing the author to see when a chord has 
multiple valid names in different scales or when the root note is different 
(ie. a different inversion of the chord).  Whichever chord match is in effect 
for a chord determines which root note EOF writes.  If the user manually named 
a chord, it looks at the name to derive the appropriate scale (ie. the first 
one or two characters in the name).

For RB3, one root note is needed at each position in the track that contains a 
chord.

Original comment by raynebc on 30 May 2013 at 9:36

GoogleCodeExporter commented 9 years ago

IF v67 does indeed set root note correctly (I still cant get it to work), the 
only other issue related to this is documented under issue 67.

Original comment by columbo...@gmail.com on 15 Jul 2013 at 6:37

GoogleCodeExporter commented 9 years ago

v70 update: Only 2 anomalies remain and both are in other issues.  so if root 
note and fret # set (its not an older pro) then this should not be its own 
issue now.

Original comment by columbo...@gmail.com on 1 Apr 2014 at 5:17

Changed state: Verified

columbo777 / ziggy-pro-editor

MIDI does not meet magma standards #43