hand and fret positions do not set for older versions

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Take a PRO created in an way older version
2. recompile
3. new 108 events are not generated.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
66/67

Please provide any additional information below.

attached

Original issue reported on code.google.com by columbo...@gmail.com on 7 Jul 2013 at 3:27

Attachments:

• SanTropez.rar

[GoogleCodeExporter]

ERROR: MIDI Compiler: d:/rbn/garden/nyxyxylyth/santropez/santropez.mid (PART 
REAL_BASS): fret is too far away from left hand position on gem at 110:4:360
ERROR: MIDI Compiler: d:/rbn/garden/nyxyxylyth/santropez/santropez.mid (PART 
REAL_GUITAR): fret is less than left hand position on gem at 43:3:000
ERROR: MIDI Compiler: d:/rbn/garden/nyxyxylyth/santropez/santropez.mid (PART 
REAL_BASS_22): fret is too far away from left hand position on gem at 110:4:360
ERROR: MIDI Compiler: d:/rbn/garden/nyxyxylyth/santropez/santropez.mid (PART 
REAL_GUITAR_22): fret is less than left hand position on gem at 43:3:000

Original comment by columbo...@gmail.com on 8 Jul 2013 at 2:39

[GoogleCodeExporter]

EOF did not correct this issue either

Original comment by columbo...@gmail.com on 8 Jul 2013 at 2:40

[GoogleCodeExporter]

The offending note in the bass track (at 110:4:360) seems to be incorrectly 
written in the MIDI.  The note is a string mute, but those notes still have a 
fret value defined, and this note's given velocity is 96, which is less than 
the least usable value of 100.  EOF doesn't have special handling for this kind 
of error so it doesn't correct it.

I'm not completely sure what the guitar track issue is.  I don't see that 
there's a gem at 43:3:000, although the gem authored in easy, medium and hard 
ends there.  Assuming the compiler meant 44:3:000 instead, that is where the 
shift slide ends on fret 4.  In this case, however, EOF seems to be set the 
fret hand position to 4 when this note is reached.  Ziggy's MIDI sets the fret 
hand position to 4 at this position, but it also ends the fret hand marker from 
the previous note at the same delta time (instead of ending the marker at the 
end of the previous note where it was set, ie. the open note at the beginning 
of the previous measure), which may be contributing to the problem.

Original comment by raynebc on 9 Jul 2013 at 8:14

[GoogleCodeExporter]

I guess regarding the bass issue, I don't know what the note should have been, 
EOF just interpreted it as a string mute due to the invalid fret value.

Original comment by raynebc on 9 Jul 2013 at 8:23

[GoogleCodeExporter]

Regarding the guitar issue, regarding 44:3:000, the MIDI does define the events 
out of proper order.  The notes at fret 4 are defined in the MIDI before the 
fret hand position marker sets the position to 4.  EOF avoids this kind of 
issue by sorting all MIDI events so that the fret hand position marker is 
written before the guitar gems at that position.

Original comment by raynebc on 9 Jul 2013 at 8:29

[GoogleCodeExporter]

Interestingly, this was made with a very early version and there is no muted 
bass note in my chart.  

BUT, I do know what its tripping the error (I think), which is because of 4 
notes next to 11 notes.  When the REDUCTIONS are done, the 11 note was left, 
but the fret marker was still 4.  I made a major correction to the BASS tracks 
themselves which I hope will fix this.  But it could happen legitimately in the 
future.  

Original comment by columbo...@gmail.com on 9 Jul 2013 at 2:51

[GoogleCodeExporter]

I think this is still a variation of issue 67 as even if I make a jump like 
that (from 4 to 11), that should be valid (and its not?).

Original comment by columbo...@gmail.com on 15 Jul 2013 at 6:27

[GoogleCodeExporter]

work around for older .mid files: run through midi cleaner, EoF or rebuild.

Original comment by columbo...@gmail.com on 1 Apr 2014 at 5:18

• Changed state: WontFix